Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): fix electron version of riscv64 #1959

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package_linux_bin.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ if [[ "${VSCODE_ARCH}" == "riscv64" ]]; then
export VSCODE_ELECTRON_REPO='riscv-forks/electron-riscv-releases'
export ELECTRON_SKIP_BINARY_DOWNLOAD=1
export PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1
ELECTRON_VERSION="v29.4.0"
ELECTRON_VERSION="v30.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version here should match .yarnrc to avoid native node module ABI breakage.

Upstream is still using v29.4.0. Is there any specific reason to bump to v30.2.0?
https://github.com/microsoft/vscode/blob/1.91.1/.yarnrc#L2

ELECTRON_CHECKSUM="0066063586114108a18126764021664908598d2ea6154e10b05514497a70df03"
# Look for releases here if electron version used by vscode changed
# https://github.com/riscv-forks/electron-riscv-releases/releases
export VSCODE_ELECTRON_TAG="${ELECTRON_VERSION}.riscv2"
echo "7244465fe0c1a6ac6e34fe765a9d90fe0017b1a6d3406fd6b8dd9f5d2c8c9df5 *electron-v29.4.0-linux-riscv64.zip" >> build/checksums/electron.txt
export VSCODE_ELECTRON_TAG="${ELECTRON_VERSION}.riscv1"
echo "${ELECTRON_CHECKSUM} *electron-${ELECTRON_VERSION}-linux-riscv64.zip" >> build/checksums/electron.txt
fi

if [[ -d "../patches/linux/client/" ]]; then
Expand Down