Improve PE File & Program Icon Loading #670
Merged
+732
−501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEFile Improvements
FileHandle
after parsingOptionalHeader
not differentiating PE32 and PE32+I think it would be best to cache the icons as it seems to take a bit to load them to find the best / largest one.
I would recommend https://github.com/kean/Nuke but there are many options and even the possibility to create a cache without any dependencies if that is desired.
Adding a dependency should be the decision of the maintainer and if they think adding a cache, and also which library to use if any, then I would be happy to implement that as well.