Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web_skin_dart all.dart export usages - manual fixup to use component-specific imports #271

Closed
wants to merge 1 commit into from

Conversation

sourcegraph-wk
Copy link

web_skin_dart has exports for individual components and an "all" export that has all components. If everywhere uses the individual component exports, then the compiler will only have to consider the component code it needs, resulting in faster build times. But, this only works if everywhere is using the individual component exports.

This batch removes the all.dart import. It will require manual fixup using an IDE's fix suggestions to import the component exports. If you would like to help us fan out and do this simple manual work to get rid of all analyzer errors, that would be fantastic. Once CI is green, you can review and merge it. Be careful to only import component2 exports. If you import the old component1 symbols, your components may break or regress.

Since the same symbols will be used, static analysis and CI passing should be sufficient for QA +1.

For more info reach out to Tom Connell on Slack.

Created by Sourcegraph batch change Workiva/web_skin_dart_all_import.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sourcegraph-wk sourcegraph-wk deleted the batch/caret/web_skin_dart_all_import branch March 1, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants