Remove web_skin_dart all.dart export usages - manual fixup to use component-specific imports #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web_skin_dart has exports for individual components and an "all" export that has all components. If everywhere uses the individual component exports, then the compiler will only have to consider the component code it needs, resulting in faster build times. But, this only works if everywhere is using the individual component exports.
This batch removes the all.dart import. It will require manual fixup using an IDE's fix suggestions to import the component exports. If you would like to help us fan out and do this simple manual work to get rid of all analyzer errors, that would be fantastic. Once CI is green, you can review and merge it. Be careful to only import
component2
exports. If you import the old component1 symbols, your components may break or regress.Since the same symbols will be used, static analysis and CI passing should be sufficient for QA +1.
For more info reach out to Tom Connell on Slack.
Created by Sourcegraph batch change
Workiva/web_skin_dart_all_import
.