Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web_skin_dart all.dart export usages - manual fixup to use component-specific imports #271

Closed
wants to merge 1 commit into from
Closed

Remove web_skin_dart all.dart export usages - manual fixup to use component-specific imports #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/executables/mui_migration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ dependencies:'''),
script: muiCodemodScript,
input: inputFiles(additionalFilesInLib: [
d.file('usage2.dart', /*language=dart*/ '''
import 'package:web_skin_dart/component2/all.dart';


usage() => ButtonToolbar()(
Button()(),
Expand All @@ -142,7 +142,7 @@ dependencies:'''),
expectedOutput: expectedOutputFiles(additionalFilesInLib: [
d.file('usage2.dart', /*language=dart*/ '''
import 'package:react_material_ui/react_material_ui.dart' as mui;
import 'package:web_skin_dart/component2/all.dart';


usage() => ButtonToolbar()(
mui.Button()(),
Expand All @@ -158,7 +158,7 @@ import 'package:web_skin_dart/component2/all.dart';
script: muiCodemodScript,
input: inputFiles(additionalFilesInLib: [
d.file('usage2.dart', /*language=dart*/ '''
import 'package:web_skin_dart/component2/all.dart';


usage() => ButtonToolbar()(
Button()(),
Expand All @@ -171,7 +171,7 @@ import 'package:web_skin_dart/component2/all.dart';
expectedOutput: expectedOutputFiles(additionalFilesInLib: [
d.file('usage2.dart', /*language=dart*/ '''
import 'package:react_material_ui/react_material_ui.dart' as mui;
import 'package:web_skin_dart/component2/all.dart';


usage() => mui.ButtonToolbar()(
mui.Button()(),
Expand All @@ -196,7 +196,7 @@ import 'package:web_skin_dart/component2/all.dart';
script: muiCodemodScript,
input: inputFiles(additionalFilesInLib: [
d.file('usage2.dart', /*language=dart*/ '''
import 'package:web_skin_dart/component2/all.dart';


usage() => ButtonToolbar()(
Button()(),
Expand Down
4 changes: 2 additions & 2 deletions test/mui_suggestors/components/shared.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@

String withOverReactAndWsdImports(String source) => /*language=dart*/ '''
import 'package:over_react/over_react.dart';
import 'package:web_skin_dart/component2/all.dart';
import 'package:web_skin_dart/component2/all.dart' as wsd_v2;


import 'package:web_skin_dart/ui_components.dart' as wsd_v1;
import 'package:web_skin_dart/component2/toolbars.dart' as toolbars_v2;
import 'package:web_skin_dart/toolbars.dart' as toolbars_v1;
Expand Down
2 changes: 1 addition & 1 deletion test/test_fixtures/wsd_project/lib/analysis_warmup.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file imports WSD and over_react and can be analyzed to warm up an
// analysis context during testing.

import 'package:web_skin_dart/component2/all.dart';

import 'package:over_react/over_react.dart';

main() {
Expand Down
8 changes: 4 additions & 4 deletions test/util/unused_import_remover_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,13 @@ void main() {
input: /*language=dart*/ '''
import 'package:over_react/over_react.dart';
import 'package:web_skin_dart/ui_components.dart';
import 'package:web_skin_dart/component2/all.dart' as wsd2;


content() => wsd2.Button()();
''',
expectedOutput: /*language=dart*/ '''
import 'package:over_react/over_react.dart';
import 'package:web_skin_dart/component2/all.dart' as wsd2;


content() => wsd2.Button()();
''',
Expand All @@ -134,13 +134,13 @@ void main() {
input: /*language=dart*/ '''
import 'package:over_react/over_react.dart';
import 'package:web_skin_dart/ui_components.dart';
import 'package:web_skin_dart/component2/all.dart' as wsd2;


content() => wsd2.Button()();
''',
expectedOutput: /*language=dart*/ '''
import 'package:web_skin_dart/ui_components.dart';
import 'package:web_skin_dart/component2/all.dart' as wsd2;


content() => wsd2.Button()();
''',
Expand Down
Loading