LP Fix #138
Merged
LP Fix #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a catch if no significant patterns are found in lp
Changed lp tests to use the sample MERFISH data so significant patterns are found. Added a test to catch no significant patterns on the small dataset.
|
Fixes #136 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 62.88% 66.24% +3.36%
==========================================
Files 40 40
Lines 2258 2314 +56
==========================================
+ Hits 1420 1533 +113
+ Misses 838 781 -57 ☔ View full report in Codecov by Sentry. |
ckmah
requested changes
Jun 13, 2024
Added a warning to indicate that no significant patterns were found when running lp()
Moved the detection of no significant patterns found to the top of the function
added a description of when this test happens (when there are no significant patterns found)
For lp_diff_discrete, change errors to warning and immediate returns for when no significant patterns are found and when phenotype dtype is numeric.
ckmah
previously approved these changes
Jul 2, 2024
pinned dask version to >=2024.2.1
|
use new spatialdata multitable api, addresses #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a catch for no significant patterns found for lp_diff_discrete. Updated lp tests to use the sample MERFISH dataset and added a test to catch no significant patterns in the small_data dataset.