Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown in book descriptions #2161

Closed
wants to merge 1 commit into from

Conversation

MxMarx
Copy link
Contributor

@MxMarx MxMarx commented Sep 30, 2023

It would be pretty nice to have a little rich text in book descriptions, mostly so line breaks are preserved when fetching metadata.
This pull request uses turndown to convert book descriptions grabbed from Audible or iTunes into markdown, and since marked is already included to render the changelog, rendering markdown in the descriptions is pretty easy.

Alternatively, we could use the trix editor currently used for podcast episodes instead of using markdown. If this is something planned for the future, it might make more sense to store rich text descriptions as sanitized html instead of markdown. I could also make a pull request with the trix editor instead if wanted.

resolves #617
resolves #1820

also convert html descriptions from Audible and iTunes to markdown
@advplyr
Copy link
Owner

advplyr commented Sep 30, 2023

One issue I had with implementing this is descriptions are also embedded in audio file meta tags with the embed tool. I'm not sure if we want to be embedding markdown or HTML in meta tags.

If we keep this as a single description field then it makes more sense to me to use HTML since both Audible and iTunes use HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants