-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookfinder.js unit testing with mocha #2300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added test coverage tooling with Istanbul (nyc) |
This is great, thanks for digging into this. The tests for me take about 100ms when not running in a dev container. I still have to learn more about the tools but I like it so far. These decisions are easier to make because they don't impact users if we switch it up later. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the search method and the TitleCandidates and AuthorCandidates classes in BookFinder.
As you can see from the commits progression, the tests were initially written using Jest, and then re-written to use Mocha (plus Sinon and Chai).
There aren't any fundamental differences between the two implementations, but they allowed me to examine the differences between Jest and Mocha by myself. My main observations were:
It is mainly due to the last point that I think I'd recommend Mocha over Jest at this point in time. Moving to jest in the future would be relatively easy if it becomes necessary/desirable (in fact, Jest can run my Mocha test as-is without any modifications, though the other way round is not true).
I also naturally made some changes to BookFinder itself while writing the tests, some of them just refactoring changes like
this, and some additional functionality like this.
As for the tests themselves, please judge for yourself.
I tried to use parametrized testing quite a bit because it reduces repetition.
I hope the test code and descriptions speak for themselves.