Feature - Adds UpgradeableLoaderInstruction::Migrate
#4661
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Lichtso
force-pushed
the
feature/loader_v3_to_v4_migration
branch
2 times, most recently
from
ba4a1ef to
d9db125
Compare
programs/bpf_loader/src/lib.rs
Outdated
| )?; | ||
|
|
||
| invoke_context.native_invoke( | ||
| solana_loader_v4_interface::instruction::truncate_uninitialized( |
There was a problem hiding this comment.
Does truncate also increase the account size? If so, the name might be misleading.
There was a problem hiding this comment.
Yes, Truncate can also increase the size and it is common for file systems to only have one function for both directions: https://www.man7.org/linux/man-pages/man2/truncate.2.html
There was a problem hiding this comment.
I see linux use the same naming, but we can improve our designation and call it resize.
Truncate means shortening: https://www.collinsdictionary.com/dictionary/english/truncate
Lichtso
force-pushed
the
feature/loader_v3_to_v4_migration
branch
from
d9db125 to
c526f4d
Compare
|
Yep, also still have to write a test for the new instruction. |
Lichtso
force-pushed
the
feature/loader_v3_to_v4_migration
branch
5 times, most recently
from
a5b2de4 to
a141a1a
Compare
Lichtso
force-pushed
the
feature/loader_v3_to_v4_migration
branch
from
a141a1a to
54d9b87
Compare
Lichtso
force-pushed
the
feature/loader_v3_to_v4_migration
branch
from
54d9b87 to
79d93ad
Compare
Problem
See SIMD-0167.
Summary of Changes
Feature Gate Issue: https://github.com/anza-xyz/feature-gate-tracker/issues/78