[Region Migration] Ignore exception when region migration considering unknown nodes. #14433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangchao316
reviewed
Dec 16, 2024
| @@ -407,6 +407,8 @@ public void removeRemotePeer(ConsensusGroupId groupId, Peer peer) throws Consens | |||
| LOGGER.info("[{}] wait {} to release all resource...", CLASS_NAME, peer); | |||
| impl.waitReleaseAllRegionRelatedResource(peer); | |||
| } catch (ConsensusGroupModifyPeerException e) { | |||
| LOGGER.error( | |||
There was a problem hiding this comment.
hi, why does remove this error log? if is a undeal exception, we can print warn.
There was a problem hiding this comment.
use warn log is better
There was a problem hiding this comment.
@wangchao316 @OneSizeFitsQuorum thanks for advise! I will fix it in #14455, since this pr is deprecated
OneSizeFitsQuorum
requested changes
Dec 16, 2024
| @@ -407,6 +407,8 @@ public void removeRemotePeer(ConsensusGroupId groupId, Peer peer) throws Consens | |||
| LOGGER.info("[{}] wait {} to release all resource...", CLASS_NAME, peer); | |||
| impl.waitReleaseAllRegionRelatedResource(peer); | |||
| } catch (ConsensusGroupModifyPeerException e) { | |||
| LOGGER.error( | |||
There was a problem hiding this comment.
use warn log is better
| isFirstCheckForOtherPeers); | ||
| try { | ||
| isTransmissionCompleted &= | ||
| isRemotePeerConsensusPipesTransmissionCompleted( |
There was a problem hiding this comment.
do we need to add this for waitTargetPeerToPeersTransmissionCompleted?
|
refer new pr #14455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.