Update Dependencies #309
Open
Update Dependencies #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: update Java 8 and Zookeeper installation
|
Can one of the admins verify this patch? |
|
yes |
DLotts
requested changes
Sep 28, 2020
| echo "Setting up environment..." | ||
| export JAVA_HOME=/usr/lib/jvm/java-8-oracle | ||
| export JAVA_HOME=/usr/lib/jvm/java-7-openjdk-amd64/jre/bin/java |
There was a problem hiding this comment.
So this sort of works because tomcat7 depends on java-7, so it gets auto installed. The jdk-8 install fails as it is not in the PPA for Ubuntu 14.04.
DLotts
reviewed
Oct 9, 2020
| sudo -E apt-get -qq install -y oracle-java8-installer || exit $? | ||
| sudo ln --force -s /usr/lib/jvm/java-8-oracle/ /usr/lib/jvm/default-java | ||
|
|
||
| sudo -E apt-get install openjdk-8-jre |
There was a problem hiding this comment.
jdk v8 is not officially supported on the version of ubuntu used by this image:
https://askubuntu.com/questions/464755/how-to-install-openjdk-8-on-14-04-lts/944260#944260
Looking for input on this. I think we should use a newer Ubuntu LTS version. I am trying "bento/ubuntu-18.04"
|
I'd really like this one to get in the release. I am having issues with
it. Perhaps the world has changed too much since the PR was submitted.
The issue is:
JRE/JDK v8 is not officially supported on the version of ubuntu used by
this image specified in the Vagrantfile patched in the PR. See this
summary answer:
https://askubuntu.com/questions/464755/how-to-install-openjdk-8-on-14-04-lts/944260#944260
I think we should use a newer Ubuntu LTS version. I am trying
"bento/ubuntu-18.04"
Looking for input on this.
david.
… You can view, comment on, or merge this pull request online at:
#309
File Changes
- *M* extras/vagrantExample/src/main/vagrant/Vagrantfile
<https://github.com/apache/incubator-rya/pull/309/files#diff-0> (60)
|
|
I am definitely going to check that as soon as possible when I have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: update Java 8 and Zookeeper installation
Description
Tests
N/A
Links
N/A
Checklist
People To Reivew
[Add those who should review this]