Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage fixes #235

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Test coverage fixes #235

merged 5 commits into from
Apr 20, 2021

Conversation

elenadimitrova
Copy link
Contributor

@elenadimitrova elenadimitrova commented Apr 14, 2021 •
edited
Loading

  • Due to 0.6 receive fallback function instrumented sc-forks/solidity-coverage#516 we've had to remove the extra property of the Received event
  • Test coverage in CI wasn't failing properly when any of its tests had failed so here we pass coverage script errors to CI.
  • Speed up coverage run by removing instrumentation for functions and statements as well as a couple of obsolete compile steps in CI

@elenadimitrova elenadimitrova self-assigned this Apr 14, 2021
@elenadimitrova elenadimitrova force-pushed the maintenance/fix-tests-under-coverage branch 2 times, most recently from 39bb975 to 957ad12 Compare April 15, 2021 13:39
@elenadimitrova elenadimitrova force-pushed the maintenance/fix-tests-under-coverage branch 3 times, most recently from 3923844 to 09e16fd Compare April 15, 2021 15:11
@elenadimitrova elenadimitrova force-pushed the maintenance/fix-tests-under-coverage branch from 09e16fd to 8c903b8 Compare April 16, 2021 05:47
@elenadimitrova elenadimitrova marked this pull request as ready for review April 16, 2021 10:44
@olivdb olivdb merged commit a3256ec into develop Apr 20, 2021
@olivdb olivdb deleted the maintenance/fix-tests-under-coverage branch April 20, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juniset juniset juniset approved these changes

Assignees

@elenadimitrova elenadimitrova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elenadimitrova @juniset @olivdb