Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage fixes #235

Merged
merged 5 commits into from
Apr 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .solcover.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module.exports = {
client: require('ganache-cli'),
measureStatementCoverage: false,
measureFunctionCoverage: false,
skipFiles: [
"../contracts-test",
"../lib_0.5",
Expand Down
2 changes: 1 addition & 1 deletion lib_0.5/compound/CEther.sol
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ contract CEther is CToken {

function doTransferOut(address payable to, uint amount) internal returns (Error) {
/* Send the Ether, with minimal gas and revert on failure */
to.transfer(amount);
to.call.value(amount)("");
return Error.NO_ERROR;
}

Expand Down
2 changes: 1 addition & 1 deletion lib_0.5/maker/WETH9.sol
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ contract WETH9 {
function withdraw(uint wad) public {
require(balanceOf[msg.sender] >= wad);
balanceOf[msg.sender] -= wad;
msg.sender.transfer(wad);
msg.sender.call.value(wad)("");
emit Withdrawal(msg.sender, wad);
}

Expand Down
2 changes: 1 addition & 1 deletion lib_0.7/yearn/yVault.sol
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ contract yVault is ERC20 {
}

IWETH(address(token)).withdraw(r);
payable(msg.sender).transfer(r);
payable(msg.sender).call{value: r}("");
}

function withdrawAllETH() external {
Expand Down
Loading