-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a naive sparse histogram. #446
Conversation
Click here to view all benchmarks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 93.24% 93.14% -0.10%
==========================================
Files 47 47
Lines 2012 2014 +2
==========================================
Hits 1876 1876
- Misses 136 138 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Added just a minor comment.
We really just need the non-zero indexes and non-zero values, and the complexity of the general scipy sparse array is adding a lot of compute overhead. This simplifies the API.
This is a breaking change for LSDB and hats-import, and PRs are coming with fixes for those repos.