Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CodeDeploy deployment config name parameter #540

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

project0
Copy link
Contributor

Issue #, if available:

Description of changes:
Allows to overwrite the desired deployment configuration for CodeDeploy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@snoworc
Copy link

snoworc commented Mar 19, 2024

Duplicate of #506 ?

@amazreech
Copy link
Contributor

Hi @project0,

Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request.
In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:

  1. Verify if PR follows semantic pull request conventions.

  2. Please run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR

@project0 project0 force-pushed the feat/codedeploy-config-name branch 2 times, most recently from c520da6 to e0947da Compare May 13, 2024 07:37
@project0
Copy link
Contributor Author

Please run npm run package command to update dist/ folder with latest dependencies.

@amazreech looks like the CI does not like that

@amazreech
Copy link
Contributor

Please run npm run package command to update dist/ folder with latest dependencies.

@amazreech looks like the CI does not like that

Hi @project0, is there any issue you are facing when trying to npm run package to update the dist folder?

@project0
Copy link
Contributor Author

project0 commented Jun 4, 2024

@amazreech
Copy link
Contributor

amazreech commented Jun 4, 2024

@amazreech https://github.com/aws-actions/amazon-ecs-deploy-task-definition/blob/master/.github/workflows/package.yml#L35-L38 PRs from contributors are not supposed to update the dist file.

@project0 Thank you for your response, as per the current setup, I believe the line of code git diff --exit-code dist/index.js runs if the PR is not made by a dependabot and returns exit code 0 (Pass) if there are no differences and non-zero (Fail) if there are any differences.

For the git diff --exit-code dist/index.js to have no differences (exit code 0 | Package Check to pass) the dist file needs to updated to contain latest changes.

Please let me know if there any additional concerns you might have.

docs: make description for "service" parameter less ambiguous.
@project0 project0 force-pushed the feat/codedeploy-config-name branch from e0947da to aacf9df Compare June 4, 2024 15:59
@project0 project0 force-pushed the feat/codedeploy-config-name branch from 9298e3c to 8afb098 Compare June 4, 2024 16:04
Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amazreech amazreech merged commit 4b15394 into aws-actions:master Jun 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants