-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CodeDeploy deployment config name parameter #540
feat: add CodeDeploy deployment config name parameter #540
Conversation
Duplicate of #506 ? |
Hi @project0, Thank you for your Patience. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request.
|
c520da6
to
e0947da
Compare
@amazreech looks like the CI does not like that |
Hi @project0, is there any issue you are facing when trying to |
@amazreech https://github.com/aws-actions/amazon-ecs-deploy-task-definition/blob/master/.github/workflows/package.yml#L35-L38 |
@project0 Thank you for your response, as per the current setup, I believe the line of code For the Please let me know if there any additional concerns you might have. |
docs: make description for "service" parameter less ambiguous.
e0947da
to
aacf9df
Compare
9298e3c
to
8afb098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue #, if available:
Description of changes:
Allows to overwrite the desired deployment configuration for CodeDeploy
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.