Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CodeDeploy deployment config name parameter #540

Merged
merged 3 commits into from
Jun 4, 2024
Merged

feat: add CodeDeploy deployment config name parameter #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aacf9df
Merge pull request #539 from lmller/patch-1
amazreech Jun 4, 2024
8afb098
Merge branch 'master' into feat/codedeploy-config-name
project0 Jun 4, 2024
7fbb269
update dist
project0 Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ inputs:
codedeploy-deployment-description:
description: "A description of the deployment, if the ECS service uses the CODE_DEPLOY deployment controller."
required: false
codedeploy-deployment-config:
description: "The name of the AWS CodeDeploy deployment configuration, if the ECS service uses the CODE_DEPLOY deployment controller. If not specified, the value configured in the deployment group or `CodeDeployDefault.OneAtATime` is used as the default."
required: false
force-new-deployment:
description: 'Whether to force a new deployment of the service. Valid value is "true". Will default to not force a new deployment.'
required: false
Expand Down
5 changes: 5 additions & 0 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task

let codeDeployDescription = core.getInput('codedeploy-deployment-description', { required: false });

let codeDeployConfig = core.getInput('codedeploy-deployment-config', { required: false });

let deploymentGroupDetails = await codedeploy.getDeploymentGroup({
applicationName: codeDeployApp,
deploymentGroupName: codeDeployGroup
Expand Down Expand Up @@ -231,6 +233,9 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task
if (codeDeployDescription) {
deploymentParams.description = codeDeployDescription
}
if (codeDeployConfig) {
deploymentParams.deploymentConfigName = codeDeployConfig
}
const createDeployResponse = await codedeploy.createDeployment(deploymentParams);
core.setOutput('codedeploy-deployment-id', createDeployResponse.deploymentId);

Expand Down
5 changes: 5 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task

let codeDeployDescription = core.getInput('codedeploy-deployment-description', { required: false });

let codeDeployConfig = core.getInput('codedeploy-deployment-config', { required: false });

let deploymentGroupDetails = await codedeploy.getDeploymentGroup({
applicationName: codeDeployApp,
deploymentGroupName: codeDeployGroup
Expand Down Expand Up @@ -225,6 +227,9 @@ async function createCodeDeployDeployment(codedeploy, clusterName, service, task
if (codeDeployDescription) {
deploymentParams.description = codeDeployDescription
}
if (codeDeployConfig) {
deploymentParams.deploymentConfigName = codeDeployConfig
}
const createDeployResponse = await codedeploy.createDeployment(deploymentParams);
core.setOutput('codedeploy-deployment-id', createDeployResponse.deploymentId);

Expand Down
8 changes: 5 additions & 3 deletions index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ describe('Deploy to ECS', () => {
failures: [],
services: [{
status: 'ACTIVE',
deploymentController: {
deploymentController: {
type: 'ECS'
}
}]
Expand Down Expand Up @@ -763,7 +763,7 @@ describe('Deploy to ECS', () => {
expect(waitUntilServicesStable).toHaveBeenCalledTimes(0);
});

test('registers the task definition contents and creates a CodeDeploy deployment with custom application, deployment group and description', async () => {
test('registers the task definition contents and creates a CodeDeploy deployment with custom application, deployment group, description and config', async () => {
core.getInput = jest
.fn(input => {
return {
Expand All @@ -773,7 +773,8 @@ describe('Deploy to ECS', () => {
'wait-for-service-stability': 'TRUE',
'codedeploy-application': 'Custom-Application',
'codedeploy-deployment-group': 'Custom-Deployment-Group',
'codedeploy-deployment-description': 'Custom-Deployment'
'codedeploy-deployment-description': 'Custom-Deployment',
'codedeploy-deployment-config': 'CodeDeployDefault.AllAtOnce'
}[input];
});

Expand Down Expand Up @@ -802,6 +803,7 @@ describe('Deploy to ECS', () => {
expect(mockCodeDeployCreateDeployment).toHaveBeenNthCalledWith(1, {
applicationName: 'Custom-Application',
deploymentGroupName: 'Custom-Deployment-Group',
deploymentConfigName: 'CodeDeployDefault.AllAtOnce',
description: 'Custom-Deployment',
revision: {
revisionType: 'AppSpecContent',
Expand Down
Loading