Adds support for deleting multiple spells in the aura nerf system. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a helper function to manage the IDs of spells that should be excluded from the aura nerf system. This improves the modularity of the code and makes it easier to add or remove new spells in the future.
Nyeriah
reviewed
Jan 3, 2025
src/mod_zone_difficulty_scripts.cpp
Outdated
| @@ -47,6 +53,10 @@ class mod_zone_difficulty_unitscript : public UnitScript | |||
| if (spellInfo->HasAttribute(SPELL_ATTR0_NO_IMMUNITIES)) | |||
| return; | |||
|
|
|||
| // Use the function to skip excluded spells | |||
| if (IsExcludedSpell(spellInfo->Id)) | |||
There was a problem hiding this comment.
just checkk for the spell ids here instead of adding another iteration please
|
This fixes Ardent Defender. But the root cause is the mod scaling -1 (infinite absorb) to 0 due to implicit casts. (fix: #58). I do find adding a disables list a good choice as the current way of scaling with 1.0f is ugly. Is it possible to put ardent defender spells plus the other entries with scaling=1, mod=65 in a new disable table? That way scaling overrides and disables are separated, and there's no odd scaling with 1.0f anymore. |
|
Mod 65 means present in mythic and normal iirc if you can avoid the overhead of adding another iteration when spells are cast then feel free to redesign it module atm is not performance friendly |
…for Specific Spell IDs 1. std::unordered_set<uint32>: A static set to store the IDs of excluded spells. This maintains modularity and makes it easier to add new IDs. 2. Direct check on the set: The exclusion check (excludedSpells.count(spellInfo->Id)) is now done inline, eliminating the need to call a separate function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a helper function to manage the IDs of spells that should be excluded from the aura nerf system. This improves the modularity of the code and makes it easier to add or remove new spells in the future.