-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.4.2 #168
Release v1.4.2 #168
Conversation
This commit adds a first version of the "find my mates scenario of the RoboCup @home league 2019. Additionally an action for interviewing people is added. Also here it is not the final version.
Add the "find_my_mates" scenario and "interview action".
add classify image as an optional param
Apperently a merge conflict was in the code and that is fixed with this commit.
Fix merge conflic comments.
Feature/kaldi listen action
This commit provides a comphrehensive version of the "Find my mate" scenario. A few more information need to be added though. For example location values.
…thers. At the moment the following behaviours are needed that are defined in the "Find my mate" scenario.
Update the "Find my mates" state machine.
…into feature/Kaldi_listen_action
Feature/kaldi listen action
@alex-mitrevski @PatrickNa what is missing to merge this? Could you make your reviews please? |
There are at least a couple of open comments that should be resolved before we merge (e.g. an HSR-specific topic being hard-coded or incorrect model paths being specified). |
@@ -0,0 +1,2 @@ | |||
model_checkpoint_path: "/home/patrick/rasa/models/current/nlu/intent_classifier_tensorflow_embedding.ckpt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this file anyway?
@@ -0,0 +1,97 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not all this model data go into mas_models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I thought there was a PR for this already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no PR, but there is an issue (#171) which is assigned to you, could you move them there when you get the chance?
@@ -0,0 +1,259 @@ | |||
senbei |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. Sometimes you want to compare the recognized speech to a specific list of objects... Generating it from the ontology fills the list with words that are not of interest.
To clarify the missing to-dos, please correct me if there's something missing :
|
mdr_find_people cleanup
Instead of checking matches in two hard coded text files. The algorithm now loops over all files specified in the config directory. Additionally dependencies in the package.xml have been clarified and unnecessary comments removed. TODO: change the type of the msg of this package.
…ehaviors_models Moving mdr_hri_behaviours nlu model to mas_models
@alex-mitrevski @PatrickNa checks are passing and final changes were just merged, could you please review/approve so I can merge? |
Changelog
Enhancements
move_arm_action
Fixes
mas_models
mas_navigation_tools
ros_dmp](https://github.com/b-it-bots/ros_dmp) for
mas_move_arm_action`