Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-663: Add System User Database Model Types #1465

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

Description of Changes

  • Adds SystemUserModel and SystemUserRecord types
  • Updates references to the old SystemUser type to the new SystemUserWithRoles type

Testing Notes

  • App should function like before (add user, delete user, edit user functionality)

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Jan 16, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (b3e073e) to head (ff12620).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...c/repositories/project-participation-repository.ts 83.33% 1 Missing ⚠️
api/src/repositories/user-repository.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1465   +/-   ##
=======================================
  Coverage   45.91%   45.92%           
=======================================
  Files         905      907    +2     
  Lines       23533    23537    +4     
  Branches     3492     3492           
=======================================
+ Hits        10805    10809    +4     
  Misses      12136    12136           
  Partials      592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as ready for review January 21, 2025 18:13
NickPhura
NickPhura previously approved these changes Jan 21, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻

NickPhura
NickPhura previously approved these changes Jan 21, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖱️

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@NickPhura NickPhura merged commit e22292d into dev Jan 22, 2025
23 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-663 branch January 22, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants