secp256k1-bouncy module, mark Bouncy Castle as an API dependency #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BouncyPrivKey extends SecP256K1FieldElement and therefore has an API dependency on Bouncy Castle. We should remove this dependency, but for now we'll just mark this module as having an API dependency on Bouncy Castle. Marking it as an API dependency allows us to remove declarations of direct dependencies on Bouncy Castle from modules using secp256k1-bouncy. When we remove the API dependency modules using secp256k1-bouncy will not have to change their Gradle/Maven dependency declarations. (But if they actually depend on `SecP256K1FieldElement` that will have to change) I plan on fixing this for 0.0.3 or maybe even sooner.
schildbach
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BouncyPrivKeyextendsSecP256K1FieldElementand therefore has an API dependency on Bouncy Castle. We should remove this dependency, but for now we'll just mark this module as having an API dependency on Bouncy Castle.Marking it as an API dependency allows us to remove declarations of direct dependencies on Bouncy Castle from modules using secp256k1-bouncy. When we remove the API dependency modules using secp256k1-bouncy will not have to change their Gradle/Maven dependency declarations. (But if they actually depend on
SecP256K1FieldElementthat will have to change)I plan on fixing this for 0.0.3 or maybe even sooner.