-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing the RTC configuration #1005
Allow changing the RTC configuration #1005
Conversation
0a60e4b
to
956651c
Compare
Just by adding the blueSim IP on the 'Global Vehicle Address' I could control the sim's ROV but the video stream didn't show up, even after I tinkered a lot with the configs. Should it have worked? Maybe I'm missing some config steps.. |
Have you accessed by that URL with query parameters? |
Yes, just changing the 'BLUE-SIM-IP' to the current one Let me try again anyway |
Remember that the BlueSim has a 5min inactivity shutdown. Once it starts, you have that time to connect. From my experience, the ardupilot instance continues to run for 30 minutes, but the MCM does not. |
I feel like this is a problem with your BlueSim instance shutting down, but I will call you after lunch so we can check. |
4f2e9aa
to
14d0fbf
Compare
It was mistakenly removed on a recent commit.
…rest` The `:6040` path does not work with BlueSim, for example.
120bd02
to
e1fefa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a checkbox to enable/disable (with text fading) to the Custom RTC configuration?
It's not clear if what is in there is already being used, or if any modifications are enabled or not:
Good idea! Done! |
This patch allows a persistent configuration of the WebRTC configurations. This allow the usage of Cockpit with BlueSim.
To test it, open a BlueSim instance and access the following address:
http://localhost:5173/?webRTCConfiguration={"iceServers":[{"urls":"stun:stun.l.google.com:19302"}]}&webRTCSignallingURI=ws://BLUE-SIM-IP:6041
You can also remove the "webRTCConfiguration" from the query parameters and set it directly in the general configuration menu. The "webRTCSignallingURI" parameter is needed since setting it in the menu is broken until #938 is merged.
Fix #925