Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the RTC configuration #1005

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jun 14, 2024

This patch allows a persistent configuration of the WebRTC configurations. This allow the usage of Cockpit with BlueSim.

To test it, open a BlueSim instance and access the following address:

http://localhost:5173/?webRTCConfiguration={"iceServers":[{"urls":"stun:stun.l.google.com:19302"}]}&webRTCSignallingURI=ws://BLUE-SIM-IP:6041

You can also remove the "webRTCConfiguration" from the query parameters and set it directly in the general configuration menu. The "webRTCSignallingURI" parameter is needed since setting it in the menu is broken until #938 is merged.

image

Fix #925

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-tun-stun-config branch from 0a60e4b to 956651c Compare June 18, 2024 00:49
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review June 18, 2024 00:49
@rafaellehmkuhl rafaellehmkuhl changed the title Allow configuration of ICE servers Allow changing the RTC configuration Jun 18, 2024
@ArturoManzoli
Copy link
Contributor

ArturoManzoli commented Jun 18, 2024

Just by adding the blueSim IP on the 'Global Vehicle Address' I could control the sim's ROV but the video stream didn't show up, even after I tinkered a lot with the configs.

Should it have worked?

Maybe I'm missing some config steps..

@rafaellehmkuhl
Copy link
Member Author

Just by adding the blueSim IP on the 'Global Vehicle Address' I could control the sim's ROV but the video stream didn't show up, even after I tinkered a lot with the configs.

Should it have worked?

Maybe I'm missing some config steps..

Have you accessed by that URL with query parameters?

@ArturoManzoli
Copy link
Contributor

Have you accessed by that URL with query parameters?

Yes, just changing the 'BLUE-SIM-IP' to the current one

Let me try again anyway

@rafaellehmkuhl
Copy link
Member Author

Have you accessed by that URL with query parameters?

Yes, just changing the 'BLUE-SIM-IP' to the current one

Let me try again anyway

Remember that the BlueSim has a 5min inactivity shutdown. Once it starts, you have that time to connect.

From my experience, the ardupilot instance continues to run for 30 minutes, but the MCM does not.

@ArturoManzoli
Copy link
Contributor

This is what I got:
image

using:
image

@rafaellehmkuhl
Copy link
Member Author

This is what I got:

I feel like this is a problem with your BlueSim instance shutting down, but I will call you after lunch so we can check.

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-tun-stun-config branch from 4f2e9aa to 14d0fbf Compare June 18, 2024 16:44
@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-tun-stun-config branch from 120bd02 to e1fefa3 Compare June 18, 2024 18:55
@ArturoManzoli
Copy link
Contributor

ArturoManzoli commented Jun 18, 2024

Nice, the feature works well.
About the interface, I have a suggestion:

Can you add a checkbox to enable/disable (with text fading) to the Custom RTC configuration?
It's not clear if what is in there is already being used, or if any modifications are enabled or not:

image

Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a checkbox to enable/disable (with text fading) to the Custom RTC configuration?
It's not clear if what is in there is already being used, or if any modifications are enabled or not:

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Jun 18, 2024

Nice, the feature works well. About the interface, I have a suggestion:

Can you add a checkbox to enable/disable (with text fading) to the Custom RTC configuration? It's not clear if what is in there is already being used, or if any modifications are enabled or not:

Good idea! Done!

@ArturoManzoli ArturoManzoli merged commit e0e5cbb into bluerobotics:master Jun 18, 2024
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the allow-tun-stun-config branch June 19, 2024 13:07
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jul 8, 2024
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jan 2, 2025
@ES-Alexander ES-Alexander removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 15, 2025
@ES-Alexander ES-Alexander added the docs-minimal See docs PR for suggested improvements label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-minimal See docs PR for suggested improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should allow configuring the Stun servers
3 participants