DG models #110
Merged
DG models #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😮 |
jbreue16
force-pushed
the
feature/dg
branch
3 times, most recently
from
5bb626b to
149a887
Compare
jbreue16
force-pushed
the
feature/dg
branch
2 times, most recently
from
fe5de1f to
48149d1
Compare
ronald-jaepel
force-pushed
the
feature/dg
branch
3 times, most recently
from
0feb8db to
dcd99f8
Compare
jbreue16
force-pushed
the
feature/dg
branch
2 times, most recently
from
142f09d to
094163d
Compare
jbreue16
commented
Apr 22, 2024
There was a problem hiding this comment.
This has nothing to do with the DG code ... I think Ive stumbled upon this and decided to clean this up: Theres no GMRES on unit operation level for the FV LRM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the DG scheme for the spatial semidiscretization of the model equations, as described here.
Feature parity with the FV code is subsequently addressed in #190
To-do
- [x] mixed FV/DG (will not be merged into main branch, backup saved under https://github.com/jbreue16/CADET/tree/feature/dg_backup)
- [x] pure DG