Feature parity for DG code #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
from
a5705c3 to
556c3e4
Compare
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
from
556c3e4 to
c3ff5db
Compare
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
2 times, most recently
from
a2a0339 to
24e9873
Compare
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
from
24e9873 to
2ceab87
Compare
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
4 times, most recently
from
589cfc7 to
3061e31
Compare
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
2 times, most recently
from
8ba85b6 to
f04df12
Compare
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
* LRM inlet DOF treatment * LRMP flux Jacobian analytical and AD fix * GRM allocation of deltaR * Clean up * Fix bug in LRMP DG sensitivity init
Add tolerance option to AD jacobian comparison tests Add relative tolerances to FV numerical reference tests
jbreue16
force-pushed
the
feature/dg_feature_parity
branch
from
4991086 to
b3b6b38
Compare
AntoniaBerger
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature parity for the DG models, which were implemented in #110
To-do