Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dll tests #30

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Add missing dll tests #30

merged 5 commits into from
Dec 3, 2024

Conversation

ronald-jaepel
Copy link
Collaborator

@ronald-jaepel ronald-jaepel commented Nov 28, 2024

The dll interface tests had two conditions that were not checked correctly:

  1. The dll test was supposed to compare the dll interface to the cli interface, which was never actually called. One commit fixes that and now throws an error.
  2. The dll test did not check for simulations with only one component. One commit adds a single-component case by modifying the simulation to only include one component. Now we get dimensionality errors.

@ronald-jaepel ronald-jaepel changed the title Fix dll tests Add missing dll tests Nov 28, 2024
@schmoelder schmoelder added this to the v1.0.2 milestone Dec 2, 2024
@schmoelder schmoelder merged commit 9907350 into master Dec 3, 2024
0 of 6 checks passed
@schmoelder schmoelder deleted the fix/dll-tests branch December 3, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants