Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional configs #11

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Add additional configs #11

merged 3 commits into from
Jun 24, 2024

Conversation

kelkawi-a
Copy link
Collaborator

Adds additional Airbyte configuration parameters as per the Airbyte docs.

charmcraft.yaml Show resolved Hide resolved
charmcraft.yaml Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
default: "IfNotPresent"
type: string

job-kube-socat-image:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are example values of these -image config values? A container registry URL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, updated the docs to include examples.

src/charm.py Show resolved Hide resolved
Copy link

@AmberCharitos AmberCharitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are a lot of config values, I guess you've looked at this already but I wonder if there are any that we could enforce as reasonable defaults to reduce some of the config noise. But if you need all of these you need all of these so approving :)

charmcraft.yaml Show resolved Hide resolved
@kelkawi-a kelkawi-a merged commit c00da2b into main Jun 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants