-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional configs #11
Conversation
fab33b7
to
afb9211
Compare
default: "IfNotPresent" | ||
type: string | ||
|
||
job-kube-socat-image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are example values of these -image config values? A container registry URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, updated the docs to include examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are a lot of config values, I guess you've looked at this already but I wonder if there are any that we could enforce as reasonable defaults to reduce some of the config noise. But if you need all of these you need all of these so approving :)
Adds additional Airbyte configuration parameters as per the Airbyte docs.