Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc in SUPPORT.md for disabled-strategies #1830

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

NobodyXu
Copy link
Member

For #1828 and #1721

@NobodyXu NobodyXu requested a review from passcod July 24, 2024 13:37
@ilyagr
Copy link

ilyagr commented Jul 24, 2024

Thank you very much for implementing this! This PR looks good to me as well.

Is there a plan to have an option like --force-enable-manifest-disabled-strategies or --force-enable-maintainer-unsupported-strategies?

For example, with #1721, if QuickInstall happens to make a binary available for an architecture the maintainer doesn't support, or if QuickInstall binary happens to not have a bug that the official binary does, I'd like the user to be able to use it. I'd just like them to be very aware that they are using an unsupported binary.

@passcod
Copy link
Member

passcod commented Jul 25, 2024

CLI options override manifest options already, they assume the user knows what they're doing.

@ilyagr
Copy link

ilyagr commented Jul 25, 2024

Sounds good, thanks!

This might be worth mentioning in this PR. You could add a sentence: "The user can override this by explicitly specifying --strategies on the command line."

@ilyagr
Copy link

ilyagr commented Jul 25, 2024

By the way, this means that --disable-strategies A is no longer equivalent to --strategies B,C. Perhaps this means that --disable-strategies should get its own environment variable config to make the workaround from nabijaczleweli/cargo-update#264 correct again. I might also leave a note there (Update: perhaps after this discussion is done).

SUPPORT.md Outdated Show resolved Hide resolved
@NobodyXu NobodyXu enabled auto-merge July 26, 2024 04:16
@NobodyXu NobodyXu added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit fa105bb Jul 26, 2024
22 checks passed
@NobodyXu NobodyXu deleted the NobodyXu-patch-1 branch July 26, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants