Error logging limited

[evansiroky]

Round 1 of error logging refactor. Not as many changes as #108.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (dev@4b510bf). Click here to learn what that means.
The diff coverage is 11.57%.

@@          Coverage Diff          @@
##             dev    #112   +/-   ##
=====================================
  Coverage       ?   5.13%           
  Complexity     ?      91           
=====================================
  Files          ?     129           
  Lines          ?    6751           
  Branches       ?     880           
=====================================
  Hits           ?     347           
  Misses         ?    6379           
  Partials       ?      25

Impacted Files	Coverage Δ	Complexity Δ
...nveyal/datatools/common/status/MonitorableJob.java	0% <ø> (ø)	0 <0> (?)
...ols/editor/controllers/api/SnapshotController.java	0% <0%> (ø)	0 <0> (?)
...main/java/com/conveyal/gtfs/GraphQLController.java	0% <0%> (ø)	0 <0> (?)
...ols/manager/controllers/api/ProjectController.java	10.45% <0%> (ø)	2 <0> (?)
...atools/manager/controllers/api/UserController.java	7.77% <0%> (ø)	2 <0> (?)
.../datatools/manager/controllers/DumpController.java	0% <0%> (ø)	0 <0> (?)
...atools/manager/controllers/api/NoteController.java	5.55% <0%> (ø)	2 <0> (?)
.../manager/controllers/api/DeploymentController.java	0% <0%> (ø)	0 <0> (?)
...anager/controllers/api/OrganizationController.java	15.38% <0%> (ø)	2 <0> (?)
...ools/manager/controllers/api/StatusController.java	13.04% <0%> (ø)	2 <0> (?)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b510bf...f4f49bf. Read the comment docs.

[landonreed]

Looks good, just a couple of changes.

[landonreed]

Perhaps the return type should be ObjectNode here.

[landonreed]

Remove param from javadoc if it has no description.

[landonreed]

There may be cases in the future where it's helpful to be able to just load a JSON string directly into this loadLegacy method (rather than going through a spark request). Could you keep the bulk of this function's logic and the previous function signature intact (single String param) and maybe just wrap this within the standard (Request req, Response res) function signature for the spark request?

[evansiroky]

The latest PR comments should be addressed and this should be ready to be merged.