CFE-2724: The arglist attribute now preserves spaces in arguments
#5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsewi
force-pushed
the
arglist
branch
2 times, most recently
from
515eb31 to
f36d3f5
Compare
larsewi
force-pushed
the
arglist
branch
9 times, most recently
from
b01fae4 to
97b5381
Compare
vpodzime
reviewed
Dec 8, 2023
vpodzime
previously approved these changes
Dec 8, 2023
This additional function argument enables us to avoid splitting command-line arguments extracted from the `arglist` attribute in the commands promise. Ticket: CFE-2724 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
This additional function argument enables us to avoid splitting command-line arguments extracted from the `arglist` attribute in the commands promise. Ticket: CFE-2724 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
|
@cf-bottom Jenkins please :) |
nickanderson
previously requested changes
Dec 12, 2023
The `arglist attribute in the `commands` promises now preserves whitespaces in the arguments. Whitespaces are currently not preserved on Windows, or if the `useshell` attribute is set to anything other than `"noshell"`. See ticket CFE-4294. Ticket: CFE-2724 Changelog: Commit Signed-off-by: Lars Erik Wik <[email protected]>
Added acceptance test checking that whitespaces are preserved by the `arglist` attribute in the `commands` promises. Whitespaces are currently not preserved on Windows, or if the `useshell` attribute is set to anything other than `"noshell"`. Ticket: CFE-2724 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10171/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10171/ |
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10176/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10176/ |
|
|
|
Ping @vpodzime, @nickanderson |
vpodzime
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Looks good to me. @nickanderson may disagree, but I believe people should read changelogs and not rely on a clearly buggy behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together with:
arglistattribute incommandspromises masterfiles#2804