CFE-2724: Removed quotes from arglist attribute in commands promises
#2804
Conversation
| @@ -757,7 +757,7 @@ bundle agent superhub_schema | |||
| "$(cfengine_enterprise_federation:config.bin_dir)/psql_wrapper.sh" | |||
| arglist => { | |||
| "cfdb", | |||
| `"select superhub_schema('$(sys.key_digest)');"`, | |||
| "select superhub_schema('$(sys.key_digest)');", | |||
There was a problem hiding this comment.
Assuming this change is done for 3.24.0 ... When I upgrade the first thing I will do is upgrade my policy set. So I will be running e.g. 3.18.6 with this policy for some time before I upgrade to 3.24.0.
Ideally we could handle this automatically. Seems like it could be difficult to detect reliably, but this is not an elegant transition.
People will have to duplicate all the cases where they have double quoting in argslist where the behavior changes and make sure that policy uses the right quoting based on the cfengine version.
There was a problem hiding this comment.
Yes, it would be a breaking change. Do you think we should not make it?
There was a problem hiding this comment.
Do I understand correctly? ...
- Users must locate all use of
argslistwithin their policy - Users must add the macro treatment (or similar) as done in this file if the promise using
argslistdoes not execute within a shell. - Users must NOT add the macro treatement (or similar) if the promise using
argslistuses a shell
Am I overlooking anything?
There was a problem hiding this comment.
Sounds about right :)
There was a problem hiding this comment.
Ok, we just need a good change in behavior post to outline the details I guess.
Now that whitespaces are preserved in the arglist attribute of the commands promises, we no longer need to use extra quotes. In fact, these quotes become a part of the argument, causing some methods to fail in the MPF. Ticket: CFE-2724 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
|
|
Now that whitespaces are preserved in the
arglistattribute of thecommandspromises, we no longer need to use extra quotes. In fact, these quotes become a part of the argument, causing some methods to fail in the MPF.Merge together with:
arglistattribute now preserves spaces in arguments core#5378