Don't timeout waiting for funding confirmation. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus a readme doc test fix. remove an extra file
Check if the maker's available liquidity is less than min_swap_amount Move the actual feerate calculation at tx building site. No need for extra RPC call.
mojoX911
requested review from
KnowWhoami and
Shourya742
and removed request for
KnowWhoami
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 70.58% 70.66% +0.08%
==========================================
Files 34 34
Lines 4161 4214 +53
==========================================
+ Hits 2937 2978 +41
- Misses 1224 1236 +12 ☔ View full report in Codecov by Sentry. |
the spendable balance should only include descriptor + swap balance. move the balance check clause at start of the swap to fail early. use sats in the error values not btc, as it creates exponential notation at display if the amount is very small.
Currently we are showing swap balance for both incoming and outgoing swapcoins. Which causes double count. Same thing for contract utxo list and balances. We should only care about incoming utxo and balance. Outgoing utxos are for other parties and we cannot directly spend them. Unless there is a recovery and then we redeem the outgoing via timelock, which adds back to the seed balance. Thus we never need to display outgoing/hashlock utxos and their balances.
mojoX911
force-pushed
the
01-2025-fix-stuffs
branch
from
32ccaf8 to
ea7d95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR packages many small improvements along with a big one. Taker sends a new message to maker while its waiting for the funding confirmation. Upon receiving the maker restarts the timer.
This allows us to wait for variable confirmation time (which is hard to predict in testnet) without timing out the connections.
Some other auxiliary improves:
min_offer_size. It will not listen for a swap request unless enough balance is sent to the wallet.cargo testto precommit-hook.