19655 adds reusable snackbar component to all project view tables

[tillyw]

Associated issues

fixes cityofaustin/atd-data-tech#19655

Testing

URL to test:

https://deploy-preview-1521--atd-moped-main.netlify.app/ or local

Steps to test:

this pr adds snackbar error and success messages to all of the mutations in the project view. i tried to keep all the error messages and functionality as consistent as possible.

• start with the summary page of any given project. throttle your network to 'offline' status
• try adding, updating, deleting (where applicable) the following fields or tables (or modals in some cases) and note the error messages that appear on the top right of the project page. if the update involves a modal, try turning off throttling, opening the modal, turning on throttling and making a change. if there is a template, try loading a template while offline. try your best to break things, you should get error snackbars in most cases and error logging in the console, and no wsods.
  • name
  • follow/unfollow
  • description
  • status update
  • lead
  • sponsor
  • partners
  • project type
  • public process
  • website
  • interim id
  • ecapris id
  • tags
  • subprojects
• repeat the above with throttling off and note the success messages
• repeat the steps above for the following pages and tables
  • timeline
    • phases
    • milestones
  • team
  • funding
    • sources
    • work activities
  • notes
  • files

please let me know if i have missed anything!

---

Ship list

• Code reviewed
• Product manager approved
• Product manager checked DB view dependencies
• Product manager added to QA test script if applicable
  • Will find a place to add when testing today

[mddilley]

Thanks for seeing this opportunity to clean up our feedback messages while working on the table feedback. I know that we haven't been the best about keeping this consistent as we added features over the years, and I think these updates will change that for the better in this main view.

I requested some small changes in here, and I think it is 🚢 from there. I was able to see the feedback in all places noted in the test steps. 💯

While testing, I noticed an old bug that isn't introduced in this PR with how we are closing the snackbar with setTimeout. I'll write up a separate issue.

[chiaberry]

I have tested this and tried to break it, and I cant! I will look again after the requested changes are addressed and approve then. its a lot of work and you were very thorough

[tillyw]

Thanks for seeing this opportunity to clean up our feedback messages while working on the table feedback. I know that we haven't been the best about keeping this consistent as we added features over the years, and I think these updates will change that for the better in this main view.

I requested some small changes in here, and I think it is 🚢 from there. I was able to see the feedback in all places noted in the test steps. 💯

While testing, I noticed an old bug that isn't introduced in this PR with how we are closing the snackbar with setTimeout. I'll write up a separate issue.

thanks @mddilley !! i agree with all of your edits and i'll get those incorporated shortly. snackbarHandle was driving me crazy >.< i should've just renamed it at the start but it will be pretty painless to find and replace

[tillyw]

Thanks for seeing this opportunity to clean up our feedback messages while working on the table feedback. I know that we haven't been the best about keeping this consistent as we added features over the years, and I think these updates will change that for the better in this main view.

I requested some small changes in here, and I think it is 🚢 from there. I was able to see the feedback in all places noted in the test steps. 💯

While testing, I noticed an old bug that isn't introduced in this PR with how we are closing the snackbar with setTimeout. I'll write up a separate issue.

i noticed this bug as well! once we have the snackbar defined in a single component it should make this an easier fix and hopefully prevent it from reappearing in the future

[tillyw]

I have tested this and tried to break it, and I cant! I will look again after the requested changes are addressed and approve then. its a lot of work and you were very thorough

yay, thank you!! i'm glad it stood up to the test :)

[mddilley]

i chatted with Tilly and moved a couple changes from this PR into cityofaustin/atd-data-tech#20772 so we can review and release this one today. I'll start reviewing shortly. 👀

[chiaberry]

much better name! thank you

[chiaberry]

I ran through the test steps again and i like the updated messages to refresh the page. this is a slick upgrade imo!

[mddilley]

Looks great! I reviewed the latest commits, and I verified the feedback is working in the project summary and tables. Thanks for updating! 🙌 🚀 🙌

[roseeichelmann]

I found one tiny itsy bitsy thing, when you delete a file while offline it will actually disappear and look like it was deleted despite giving the error. If you go back online and refresh the page it will be there though

[roseeichelmann]

this looks and works so well, it was such a huge undertaking and improvement! awesome to have these consistent feedback snackbars throughout the app. i found one weird behavior with the file deleting but other than that this is good to go!!

[mddilley]

@tillyw @chiaberry Heads up that I resolved a small conflict with main in here since y'all both made updates in ProjectTeamTable. it was a small change but wanted to let y'all know.

@roseeichelmann Thanks for finding that bug! Maybe there is a state update that happens before the mutation fails. I'll write up an issue! 📝 🙏

[tillyw]

@tillyw @chiaberry Heads up that I resolved a small conflict with main in here since y'all both made updates in ProjectTeamTable. it was a small change but wanted to let y'all know.

@roseeichelmann Thanks for finding that bug! Maybe there is a state update that happens before the mutation fails. I'll write up an issue! 📝 🙏

thanks @mddilley for resolving that conflict! @roseeichelmann thanks for catching that! i noticed that behavior as well, and i think it would be worth addressing in a follow-up issue. thanks mike for making an issue for that as well!