HTTPS support #21
Merged
HTTPS support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to check at every call which one to use.
We don't want to maintain this: it is up to the user to provide a cert store, like with the vanilla LuaSec library.
jdesgats
force-pushed
the
https
branch
2 times, most recently
from
4a30c82 to
1be557f
Compare
Stick with LuaSec API conventions (as this parameter is LuaSec only anyway). Using a different name causes confusion for no reason.
StephanDollberg
approved these changes
May 16, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #18 with a few nitpicks fixed.