Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent Table from crashing when removing a column in edit state #3222

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

abdhalees
Copy link
Member

@abdhalees abdhalees commented Jan 27, 2025

Description

If a column gets removed from a table while in editing state, the table crashes.
even though we recommend to disable preferences while a table is editing, this commit should prevent the table from crashing.

Related links, issue #, if available: AWSUI-60271

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abdhalees abdhalees marked this pull request as ready for review January 27, 2025 11:58
@abdhalees abdhalees requested a review from a team as a code owner January 27, 2025 11:58
@abdhalees abdhalees requested review from dpitcock and removed request for a team January 27, 2025 11:58
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (34cd820) to head (143f149).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3222   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         791      791           
  Lines       22314    22314           
  Branches     7662     7601   -61     
=======================================
  Hits        21523    21523           
  Misses        739      739           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dpitcock dpitcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@abdhalees abdhalees enabled auto-merge January 28, 2025 09:01
@abdhalees abdhalees added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 7f23985 Jan 28, 2025
38 checks passed
@abdhalees abdhalees deleted the table-edit-error branch January 28, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants