-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use title
in place of examples
#271
Conversation
The `title` property is rendered by VJSF as dimmed placeholder text inside the field itself, which is a subtle but clear hint to the user to format the name correctly. This is simpler and less obtrusive than using `examples`, which causes VJSF to instead render a dropdown menu containing the examples. This prevents editing of an existing name and implies that the example names are the only suggested names in the system.
Co-authored-by: Satrajit Ghosh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 16 16
Lines 1753 1753
=======================================
Hits 1710 1710
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -11,6 +11,7 @@ | |||
"0.6.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think DANDI_SCHEMA_VERSION = "0.6.8"
in line 1 should change to `DANDI_SCHEMA_VERSION = "0.6.9" as well since we are publishing a new version of the schema.
I compared the generated JSON schemas with the 0.6.8 version. All differences are expected. Since both the |
Closes #270; addresses dandi/dandi-archive#2090 indirectly.
The
title
property is rendered by VJSF as dimmed placeholder text inside the field itself, which is a subtle but clear hint to the user to format the name correctly. This is simpler and less obtrusive than usingexamples
, which causes VJSF to instead render a dropdown menu containing the examples. This prevents editing of an existing name and implies that the example names are the only suggested names in the system.