Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use title in place of examples #271

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Use title in place of examples #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6bafca4
Use `title` in place of `examples`
waxlamp Dec 10, 2024
b158cfc
requires release and schema version update
satra Dec 11, 2024
daa0d70
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 11, 2024
cec33a6
Use more comprehensive title text
waxlamp Dec 11, 2024
be2e23a
Merge branch 'master' into improve-name-field-vjsf
satra Dec 16, 2024
30586fd
update schema version
satra Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dandischema/consts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DANDI_SCHEMA_VERSION = "0.6.8"
DANDI_SCHEMA_VERSION = "0.6.9"
ALLOWED_INPUT_SCHEMAS = [
"0.4.4",
"0.5.1",
Expand All @@ -11,6 +11,7 @@
"0.6.5",
"0.6.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DANDI_SCHEMA_VERSION = "0.6.8" in line 1 should change to `DANDI_SCHEMA_VERSION = "0.6.9" as well since we are publishing a new version of the schema.

"0.6.7",
"0.6.8",
]

# ATM we allow only for a single target version which is current
Expand Down
2 changes: 1 addition & 1 deletion dandischema/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,10 +946,10 @@ class Person(Contributor):
json_schema_extra={"nskey": "schema"},
)
name: str = Field(
title="Use Last, First. Example: Lovelace, Augusta Ada",
description="Use the format: familyname, given names ...",
pattern=NAME_PATTERN,
json_schema_extra={"nskey": "schema"},
examples=["Lovelace, Augusta Ada", "Smith, John", "Chan, Kong-sang"],
)
affiliation: Optional[List[Affiliation]] = Field(
None,
Expand Down
Loading