Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve module boundary #10

Closed
wants to merge 3 commits into from
Closed

Fix and improve module boundary #10

wants to merge 3 commits into from

Conversation

jcorbin
Copy link

@jcorbin jcorbin commented Mar 1, 2015

At least the minimal export commit is necessary, the other two are just nice to have.

cc @deoxxa @Raynos

@Raynos
Copy link

Raynos commented Mar 1, 2015

All lgtm.

@shinnn
Copy link
Collaborator

shinnn commented Jun 25, 2015

+1

@zertosh zertosh mentioned this pull request Nov 8, 2015
Merged
@zertosh zertosh closed this in #20 Nov 8, 2015
@zertosh
Copy link
Collaborator

zertosh commented Nov 8, 2015

@jcorbin Actually my changes from #20 didn't quite change how inheritance is done - only the exposing. Can you submit another PR with the inherits bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcorbin @Raynos @shinnn @zertosh