Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #20

Merged
merged 6 commits into from
Nov 8, 2015
Merged

Various fixes #20

merged 6 commits into from
Nov 8, 2015

Conversation

zertosh
Copy link
Collaborator

@zertosh zertosh commented Nov 8, 2015

This PR reverts many of the stylistic changes made post-v0.1.0, namely going back to es5 and not linting.

The move back to es5 is for testability purposes. Depending on transpiling and node flags just to run tests - even on the latest node - makes testing more difficult than it needs to be.

I have nothing against linting, except when they're flaky, not clear, and get in the way of testing.

The rest of the changes are fixes.

@shinnn Despite this, thank you for taking the care to modernize the tests and examples. Can you take a quick look at this? The commits are atomic.

(@shinnn edited)

fix #5
fix #7
fix #10

@zertosh
Copy link
Collaborator Author

zertosh commented Nov 8, 2015

This is an alternate example.js that shows extending the stream classes and works with node 4.x w/o flags: https://gist.github.com/zertosh/b68478fbfe54d7270961

@shinnn
Copy link
Collaborator

shinnn commented Nov 8, 2015

My goal was not to rule this project opinionatedly, but to move forward this project. and now it's achieved by @zertosh :).

Go right ahead and thanks for keep maintaining this project.

@zertosh
Copy link
Collaborator Author

zertosh commented Nov 8, 2015

Thanks @shinnn! And you too, for stepping up when things needed to get done 👍

zertosh added a commit that referenced this pull request Nov 8, 2015
@zertosh zertosh merged commit 8fac12b into deoxxa:master Nov 8, 2015
@zertosh zertosh deleted the un-es2015 branch November 8, 2015 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants