Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] Farhan/FEQ-1738/SmartCharts: JS & CSS Cleanup #1514

Merged

Conversation

farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Feb 22, 2024

Cleaning up unused js and css in smartcharts (css cleanup is mostly related to cq styles)

@farhan-nurzi-deriv farhan-nurzi-deriv requested a review from a team as a code owner February 22, 2024 02:22
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

maryia-deriv
maryia-deriv previously approved these changes Feb 22, 2024
Copy link

gitguardian bot commented Feb 22, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 587809a app/test.tsx View secret
- Generic High Entropy Secret f7ef44e app/test.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@farhan-nurzi-deriv farhan-nurzi-deriv force-pushed the farhan/FEQ-1738/css-clean-ups branch 4 times, most recently from a2dfc1a to f7ef44e Compare February 29, 2024 10:03
maryia-deriv
maryia-deriv previously approved these changes Mar 5, 2024
@farhan-nurzi-deriv farhan-nurzi-deriv force-pushed the farhan/FEQ-1738/css-clean-ups branch from 090e7b3 to 5592b5f Compare March 5, 2024 09:58
Copy link

github-actions bot commented Mar 5, 2024

Preview Link: https://pr-1514.smartcharts-preview.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@maryia-deriv maryia-deriv changed the title [FEQ] Farhan/FEQ-1738/SmartCharts: CSS Cleanup [FEQ] Farhan/FEQ-1738/SmartCharts: JS & CSS Cleanup Mar 5, 2024
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@maryia-deriv maryia-deriv merged commit d6e7bd7 into deriv-com:master Mar 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants