Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEQ] Farhan/FEQ-1738/SmartCharts: JS & CSS Cleanup #1514

Merged
2 changes: 0 additions & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"import/prefer-default-export": 0,
"jsx-a11y/no-static-element-interactions": 0,
"array-callback-return": 0,
"react/prop-types": 0,
"react/jsx-indent": 0,
"key-spacing": 0,
"object-curly-newline": 0,
Expand Down Expand Up @@ -77,7 +76,6 @@
"prefer-destructuring": 0,
"react/no-access-state-in-setstate": 2,
"react/destructuring-assignment": 0,
"react/forbid-prop-types": 0,
"react/jsx-props-no-multi-spaces": 0,
"react/jsx-one-expression-per-line": 0,
"lines-between-class-members": 0,
Expand Down
30 changes: 2 additions & 28 deletions app/DateTimePicker/date-picker.scss
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@
.calendar-date-panel,
.calendar-month-panel,
.calendar-year-panel,
.calendar-decade-panel,
.calendar-century-panel {
.calendar-decade-panel {
display: grid;
grid-gap: 0.8rem 1.2rem;
padding: 0.8rem 2rem;
Expand All @@ -139,8 +138,7 @@
}
&.calendar-month-panel,
&.calendar-year-panel,
&.calendar-decade-panel,
&.calendar-century-panel {
&.calendar-decade-panel {
grid-template-columns: repeat(3, minmax(7.2rem, 1fr));
grid-auto-rows: minmax(4.2rem, auto);
}
Expand Down Expand Up @@ -349,30 +347,6 @@
margin: 0;
}
}
.picker-calendar-icon,
.close-circle-icon {
position: absolute;
right: 12px;
top: 50%;
transform: translateY(-50%);
transition: all 0.3s;
user-select: none;
opacity: 0;
pointer-events: none;
cursor: pointer;

&:before {
content: '';
display: block;
width: 14px;
height: 14px;
background-size: 14px 14px;
}
&.show {
opacity: 1;
pointer-events: auto;
}
}
.datepicker-calendar {
.calendar {
top: 100%;
Expand Down
15 changes: 0 additions & 15 deletions app/DateTimePicker/time-picker.scss
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,6 @@
&.from-right {
right: 0;
}
.time-picker-clear {
position: relative;
float: right;
display: none;
top: 1px;
width: 17px;
height: 17px;
cursor: pointer;

svg {
@include themify($themes) {
fill: themed('ChartHistoryPickerTopColor');
}
}
}
.time-picker-selector {
display: flex;
flex-direction: row;
Expand Down
3 changes: 0 additions & 3 deletions app/connection/NetworkMonitor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ class NetworkMonitor {
this.establishConnection();
});
window.addEventListener('offline', () => this.setNetworkStatus('offline'));
} else {
// default to always online and fallback to WS checks
navigator.onLine = true;
}
this.setNetworkStatus(this.isOnline() ? 'blinking' : 'offline');
return this.establishConnection();
Expand Down
Loading
Loading