Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

George / FEQ-1990 / Transfer file utils #15

Merged
merged 9 commits into from
Apr 29, 2024
Merged

George / FEQ-1990 / Transfer file utils #15

merged 9 commits into from
Apr 29, 2024

Conversation

heorhi-deriv
Copy link
Contributor

List of Added Utils:

  1. compressImage
  2. convertToBase64
  3. isSupportedImageFormat
  4. compressImageFile
  5. numToUint8Array
  6. generateChunks
  7. readFile

By using this we can remove file-utils file from /deriv-app/packages/**api-v2**/src/utils/file-utils.ts.

yashim-deriv
yashim-deriv reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are related to images, maybe it should be ImageUtils ?

src/utils/file.utils.ts Outdated Show resolved Hide resolved
src/utils/file.utils.ts Outdated Show resolved Hide resolved
src/utils/file.utils.ts Outdated Show resolved Hide resolved
@heorhi-deriv heorhi-deriv reopened this Apr 1, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8753352357

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.789%
Totals Coverage Status
Change from base Build 8683166158: 0.005%
Covered Lines: 474
Relevant Lines: 474
💛 - Coveralls

@niloofar-deriv niloofar-deriv merged commit 5b6629d into deriv-com:master Apr 29, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.0.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@likhith-deriv likhith-deriv mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@matin-deriv matin-deriv matin-deriv approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heorhi-deriv @coveralls @matin-deriv @yashim-deriv @niloofar-deriv