Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo for dfx 0.12.0 #1001

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Update repo for dfx 0.12.0 #1001

merged 6 commits into from
Nov 11, 2022

Conversation

frederikrothenberger
Copy link
Contributor

@frederikrothenberger frederikrothenberger commented Nov 10, 2022

Fixes #936

This PR makes the following changes:

  • use dfx 0.12.0 in CI
  • remove deprecated network configuration from dfx.json files
  • update documentation
  • adapt using-dev-build test to read replica port by calling the dfx info command

Frederik Rothenberger added 2 commits November 10, 2022 14:47
This PR makes the following changes:
* use dfx 0.12.0 in CI
* remove deprecated network configuration from dfx.json files
* update documentation
* adapt using-dev-build test to read replica port by calling the dfx info command
.github/workflows/canister-tests.yml Outdated Show resolved Hide resolved
demos/using-dev-build/test.ts Outdated Show resolved Hide resolved
demos/using-dev-build/test.ts Outdated Show resolved Hide resolved
dfx.json Show resolved Hide resolved
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@nmattia nmattia mentioned this pull request Nov 11, 2022
@frederikrothenberger frederikrothenberger merged commit 382c259 into main Nov 11, 2022
@frederikrothenberger frederikrothenberger deleted the frederik/dfx12 branch November 11, 2022 09:36
nmattia added a commit that referenced this pull request Nov 14, 2022
This updates the test-app config to use the correct replica port (now
independent of dfx.json since
#1001) and renames the
`develop` script to `start` for consistency with the II dev server.
@nmattia nmattia mentioned this pull request Nov 14, 2022
nmattia added a commit that referenced this pull request Nov 14, 2022
This updates the test-app config to use the correct replica port (now
independent of dfx.json since
#1001) and renames the
`develop` script to `start` for consistency with the II dev server.
nmattia added a commit that referenced this pull request Nov 14, 2022
This updates the test-app config to use the correct replica port (now
independent of dfx.json since
#1001) and renames the
`develop` script to `start` for consistency with the II dev server.
frederikrothenberger pushed a commit that referenced this pull request Nov 15, 2022
This error was introduced with #1001.
frederikrothenberger pushed a commit that referenced this pull request Nov 15, 2022
This error was introduced with #1001.
nmattia pushed a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to dfx 0.12
2 participants