-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo for dfx 0.12.0 #1001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the following changes: * use dfx 0.12.0 in CI * remove deprecated network configuration from dfx.json files * update documentation * adapt using-dev-build test to read replica port by calling the dfx info command
frederikrothenberger
force-pushed
the
frederik/dfx12
branch
from
November 10, 2022 13:54
9c78aae
to
fe783ac
Compare
nmattia
reviewed
Nov 10, 2022
frederikrothenberger
force-pushed
the
frederik/dfx12
branch
from
November 10, 2022 15:48
d3f6283
to
b24af14
Compare
nmattia
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Closed
nmattia
added a commit
that referenced
this pull request
Nov 14, 2022
This updates the test-app config to use the correct replica port (now independent of dfx.json since #1001) and renames the `develop` script to `start` for consistency with the II dev server.
Merged
nmattia
added a commit
that referenced
this pull request
Nov 14, 2022
This updates the test-app config to use the correct replica port (now independent of dfx.json since #1001) and renames the `develop` script to `start` for consistency with the II dev server.
nmattia
added a commit
that referenced
this pull request
Nov 14, 2022
This updates the test-app config to use the correct replica port (now independent of dfx.json since #1001) and renames the `develop` script to `start` for consistency with the II dev server.
frederikrothenberger
pushed a commit
that referenced
this pull request
Nov 15, 2022
This error was introduced with #1001.
frederikrothenberger
pushed a commit
that referenced
this pull request
Nov 15, 2022
This error was introduced with #1001.
nmattia
pushed a commit
that referenced
this pull request
Nov 15, 2022
This error was introduced with #1001.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936
This PR makes the following changes: