-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spanish readme and first intro #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all suggestions, I'm from Argentina where we speak Spanish but not quite the same one as in Spain (we tend to use different words for the same thing, and conjugate the verbs in a different way). I did my best to try and suggest what it is mostly neutral Spanish.
performance-es.md
Outdated
|
||
1. Consejos básicos para escribir software que no sea lento. | ||
* Temas básicos de Ciencias de la Computación | ||
2. Consejos para escribir software rápido. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/rápido/veloz/
. While they are synonyms, software rápido
sounds more like fast software, whereas software veloz
to me sounds more like performant software
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt about this one, since the original text is fast software
here. If in any case makes for a better understanding I am ok changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about this one @rocajuanma?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, fast software == software rápido
but escribir software rápido
could be interpreted as write software in a fast way
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inkel has a very good point here. I personally like ‘software rápido’, but it could be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like: Consejos para escribir software eficiente
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted for eficiente
in the end as a middle ground as @grevych suggested
performance-es.md
Outdated
* Temas básicos de Ciencias de la Computación | ||
2. Consejos para escribir software rápido. | ||
* Secciones específicas de Go sobre cómo obtener lo mejor del lenguaje | ||
3. Consejos avanzados para escribir * software realmente * rápido |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I'd replace rápido
with veloz
.
Thanks for taking a look! |
My comments are also just suggestions. I'm Peruvian but live in Canada. |
|
||
Hay diferentes maneras de contribuir: | ||
|
||
1) agregar o resumir los recursos en el fichero [TODO](TODO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agregrar o resumir los recursos en el archivo/folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I like archivo
way better than fichero
, in Spanish the right translation for file
is fichero
(to the best of my knowledge). I wouldn't use folder
.
|
||
### Cómo contribuir | ||
|
||
Este es un libro en desarrollo sobre rendimiento y optimización en Go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Este es un libro en desarrollo de software especializado en rendimiento y optimización en Go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the word desarrollo
actually refers to the state of the document. The document is under development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understood in the original text, the work-in-progress refers to the book itself. I find the suggestion changes the original meaning in this case. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I think the current version is clear enough about the book been under development.
@marc-gr I'm very interested in continuing this translation work. Once this PR is merged, I might start a new one with a new topic. Wanted to reach out to you or any other person interested to see how we can divide the work/chapters, and perhaps set some standards on the translation. Let me know your thoughts. cc @inkel @dgryski @grevych @irivera007 Really like how a couple of Spanish speaking gophers came together for this 💯 |
Let me know when this is ready to merge. |
Added extra bunch of suggestions :) @rocajuanma absolutely! I am in the @gophers slack, we can chat about it there with anyone interested in helping. @inkel @grevych @irivera007 @rocajuanma if you do not see anything obvious remaining, IMO looks good to merge now. |
@marc-gr looks good to me! |
Me too! Ping me in |
+1 |
+1 Let's chat on slack! 👍 |
This is related to this open issue: #13
I took the freedom of kickstarting it, since it seems to be inactive. If it is not the case feel free to let me know and I will happily contribute to the current efforts :)
cc @Jamez312 @gonzaloserrano