feat: set output optional for presistent cache #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the
RegisterPersistentCachePeerRequest
structure and its validation logic, as well as a version bump for thedragonfly-api
package. The most important changes include making theoutput_path
field optional and updating the validation logic accordingly.Changes to
RegisterPersistentCachePeerRequest
structure:pkg/apis/scheduler/v2/scheduler.proto
: Changed theoutput_path
field to be optional and added validation rules to ignore empty strings.proto/scheduler.proto
: Updated theoutput_path
field to be optional.src/scheduler.v2.rs
: Modified theoutput_path
field to useOption
type, making it optional.Updates to validation logic:
pkg/apis/scheduler/v2/scheduler.pb.validate.go
: Added checks forTag
,Application
, andOutputPath
fields, ensuring they are validated properly. [1] [2]Version bump for
dragonfly-api
package:Cargo.toml
: Updated the version from2.1.2
to2.1.3
.Related Issue
Motivation and Context