Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set output optional for presistent cache #436

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jan 2, 2025

Description

This pull request includes several changes to the RegisterPersistentCachePeerRequest structure and its validation logic, as well as a version bump for the dragonfly-api package. The most important changes include making the output_path field optional and updating the validation logic accordingly.

Changes to RegisterPersistentCachePeerRequest structure:

Updates to validation logic:

Version bump for dragonfly-api package:

  • Cargo.toml: Updated the version from 2.1.2 to 2.1.3.

Related Issue

Motivation and Context

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 2, 2025
@gaius-qi gaius-qi self-assigned this Jan 2, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 2, 2025 14:30
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 05f657b into main Jan 3, 2025
6 checks passed
@gaius-qi gaius-qi deleted the feature/output branch January 3, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants