Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set output optional for presistent cache #436

Merged
merged 1 commit into from
Jan 3, 2025
Merged

feat: set output optional for presistent cache #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "dragonfly-api"
version = "2.1.2"
version = "2.1.3"
authors = ["Gaius <[email protected]>"]
edition = "2021"
license = "Apache-2.0"
Expand Down
610 changes: 306 additions & 304 deletions pkg/apis/scheduler/v2/scheduler.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 19 additions & 11 deletions pkg/apis/scheduler/v2/scheduler.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/scheduler/v2/scheduler.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ message RegisterPersistentCachePeerRequest {
// Task piece length.
uint64 piece_length = 5 [(validate.rules).uint64.gte = 1];
// File path to be exported.
string output_path = 6 [(validate.rules).string.min_len = 1];
optional string output_path = 6 [(validate.rules).string = {min_len: 1, ignore_empty: true}];
// Download timeout.
optional google.protobuf.Duration timeout = 7;
}
Expand Down
2 changes: 1 addition & 1 deletion proto/scheduler.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ message RegisterPersistentCachePeerRequest {
// Task piece length.
uint64 piece_length = 5;
// File path to be exported.
string output_path = 6;
optional string output_path = 6;
// Download timeout.
optional google.protobuf.Duration timeout = 7;
}
Expand Down
Binary file modified src/descriptor.bin
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions src/scheduler.v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,8 @@ pub struct RegisterPersistentCachePeerRequest {
#[prost(uint64, tag = "5")]
pub piece_length: u64,
/// File path to be exported.
#[prost(string, tag = "6")]
pub output_path: ::prost::alloc::string::String,
#[prost(string, optional, tag = "6")]
pub output_path: ::core::option::Option<::prost::alloc::string::String>,
/// Download timeout.
#[prost(message, optional, tag = "7")]
pub timeout: ::core::option::Option<::prost_wkt_types::Duration>,
Expand Down
Loading