[CLOB-976] Add mainnet indexer related config. #48
Conversation
vincentwschau
requested review from
jiajames,
Christopher-Li and
lucas-dydx
as code owners
indexer/ecr.tf
Outdated
| name = var.full_node_ecr_repository_name | ||
| } | ||
|
|
||
| data "aws_ecr_repository" "snapshot_ful_node_ap_northeast_1" { |
| @@ -12,7 +12,8 @@ resource "aws_s3_bucket" "load_balancer" { | |||
| # TODO: refactor snapshotting full node into a separate module | |||
| # AWS S3 bucket to store all Indexer full node snapshots | |||
| resource "aws_s3_bucket" "indexer_full_node_snapshots" { | |||
| bucket = var.s3_snapshot_bucket | |||
| # Use account id for mainnet to avoid name collisions | |||
| bucket = var.environment == "mainnet" ? "${local.account_id}-${var.s3_snapshot_bucket}" : var.s3_snapshot_bucket | |||
There was a problem hiding this comment.
don't we want to use account_id regardless to avoid name collisions?
There was a problem hiding this comment.
Yes, but this would lead to plans / applies that delete existing buckets so a migration is necessary.
There was a problem hiding this comment.
nit: add a todo and create a low priority ticket on the backlog?
| # in dev environments, we build separate images. | ||
| ecr_repository_url = contains(["testnet", "testnet1", "testnet2"], var.environment) ? data.aws_ecr_repository.validator.repository_url : data.aws_ecr_repository.snapshot_validator.repository_url | ||
| ecr_repository_url = contains(["testnet", "testnet1", "testnet2"], var.environment) ? local.node_ecr_repository_url : local.snapshot_node_ecr_repository_url |
There was a problem hiding this comment.
should mainnet have the same behavior as our testnet or dev/staging for the snapshot node?
There was a problem hiding this comment.
It's not currently deployed so that's an unknown right now.
There was a problem hiding this comment.
why do we have a separate ECR repo for the snapshot node if we can just use the indexer full node ECR repo in testnet?
cc: @dydxwill
There was a problem hiding this comment.
I haven't finished changing the deployment of the images for the env, so it's an unknown.
No description provided.