-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOB-976] Add mainnet indexer related config. #48
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,10 @@ module "full_node_snapshot_ap_northeast_1" { | |
datadog_api_key = var.datadog_api_key | ||
dd_site = var.dd_site | ||
|
||
# in public testnet, use the validator image which contains the snapshot script. | ||
# in public testnet, use the node image which contains the snapshot script. | ||
# in dev environments, we build separate images. | ||
ecr_repository_url = contains(["testnet", "testnet1", "testnet2"], var.environment) ? data.aws_ecr_repository.validator.repository_url : data.aws_ecr_repository.snapshot_validator.repository_url | ||
# TODO(CLOB-976): Determine if mainnet configuration uses a separate image. | ||
ecr_repository_url = contains(["testnet", "testnet1", "testnet2"], var.environment) ? local.node_ecr_repository_url : local.snapshot_node_ecr_repository_url | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should mainnet have the same behavior as our testnet or dev/staging for the snapshot node? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not currently deployed so that's an unknown right now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we have a separate ECR repo for the snapshot node if we can just use the indexer full node ECR repo in testnet? cc: @dydxwill There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't finished changing the deployment of the images for the env, so it's an unknown. |
||
|
||
ec2_instance_type = var.full_node_ec2_instance_type | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we want to use account_id regardless to avoid name collisions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this would lead to plans / applies that delete existing buckets so a migration is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a todo and create a low priority ticket on the backlog?