Add ESmini simulator #223
Merged
Add ESmini simulator #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassava
force-pushed
the
ben/esmini-simulator
branch
from
11d76de to
593a8f9
Compare
cassava
force-pushed
the
ben/esmini-simulator
branch
from
30aec1e to
0ad5fc9
Compare
cassava
commented
Mar 27, 2024
cassava
force-pushed
the
ben/esmini-simulator
branch
from
da6de28 to
358d004
Compare
cassava
force-pushed
the
ben/esmini-simulator
branch
from
1d40600 to
d6edb3d
Compare
hvolx
reviewed
Mar 27, 2024
| std::vector<std::shared_ptr<osi3::SensorData>> receive_sensor_data() override { | ||
| std::vector<std::shared_ptr<osi3::SensorData>> msgs; | ||
| bool has_sensor_view() const override { | ||
| return this->tcp_available_data() >= static_cast<std::streamsize>(sizeof(osi3::SensorView)); |
There was a problem hiding this comment.
Isnt sizeof(osi3::SensorView) the size of the deserialized protobuf message whereas the size of the message in the tcp buffer is serialized?
In my point of view the amount of data in the buffer does not give any information on which osi message is in the buffer
There was a problem hiding this comment.
Yes, this does look sketchy.
The optional directory contains projects that are hard to build. ESMini does not fall into this category, since the sources are freely available. This commit does the following: - Move optional/esmini to plugins/esmini - Move optional/osi to osi - Replace Conan recipe for vendor/esmini and vendor/esmini-data - Replace Conan recipe for vendor/open-simulation-interface - Patch the esmini and osi Cloe libraries for compatibility with new open-simulation-interface. In particular, the generated headers are now namespaced with osi3/ - Fix several findings in esmini and osi Cloe libraries highlighted by clang-tidy. The vendored libraries are written in a manner similar to how it is done in the Conan-Center-Index.
cassava
force-pushed
the
ben/esmini-simulator
branch
from
d6edb3d to
375afa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs to be rebased, but otherwise ready for review.