Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): fix error api error message parsing (Issue #1481) #1887

Merged
merged 23 commits into from
Aug 8, 2024
Merged

fix(chat): fix error api error message parsing (Issue #1481) #1887

merged 23 commits into from
Aug 8, 2024

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Aug 6, 2024

Description:

  • fix api request error message parsing

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

Magomed-Elbi Dzhukalaev and others added 14 commits July 29, 2024 18:35
fix(chat): add error messages for failed publish requests
a0e289a
@Gimir
Merge branch 'development' into fix/1481-error-notifications
c5af348
@IlyaBondar
Merge branch 'development' into fix/1481-error-notifications
cb4b42a
Merge branch 'development' of https://github.com/epam/ai-dial-chat in…
e28c616 
…to fix/1481-error-notifications
fix(chat): fix request response wrapper
17d4715
fix(chat): move error parser to ServerUtils
eb46fe3
Merge branch 'fix/1481-error-notifications' of https://github.com/epa…
ef73569 
…m/ai-dial-chat into fix/1481-error-notifications
@Gimir
Merge branch 'development' into fix/1481-error-notifications
e7a60ec
@IlyaBondar
Merge branch 'development' into fix/1481-error-notifications
b887970
@IlyaBondar
Merge branch 'development' into fix/1481-error-notifications
e485f23
@Gimir @IlyaBondar
fix(chat): refactor error message parser
1540e93 
Co-authored-by: Ilya Bondar <[email protected]>
fix(chat): run formatters
8f29d28
Merge branch 'development' of https://github.com/epam/ai-dial-chat in…
1515d23 
…to fix/1481-error-notifications
fix(chat): fix api error message parsing
ce6edbb
@Gimir
Copy link
Contributor Author

Gimir commented Aug 6, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

@Gimir Gimir self-assigned this Aug 6, 2024
@Gimir Gimir added bug Something isn't working _priority_2 labels Aug 6, 2024
@Gimir
Copy link
Contributor Author

Gimir commented Aug 7, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

IlyaBondar
IlyaBondar previously approved these changes Aug 7, 2024
View reviewed changes
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Aug 7, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Aug 7, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

3 similar comments
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Aug 7, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Aug 7, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Aug 7, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Aug 8, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Aug 8, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: success

@Gimir
Copy link
Contributor Author

Gimir commented Aug 8, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1887.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir merged commit c232d1e into development Aug 8, 2024
9 checks passed
@Gimir Gimir deleted the fix/1481-error-notifications branch August 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBondar IlyaBondar IlyaBondar approved these changes

@denys-kolomiitsev denys-kolomiitsev Awaiting requested review from denys-kolomiitsev denys-kolomiitsev is a code owner

@Alexander-Kezik Alexander-Kezik Awaiting requested review from Alexander-Kezik Alexander-Kezik is a code owner

@Derikyan Derikyan Awaiting requested review from Derikyan Derikyan is a code owner

@likeamike likeamike Awaiting requested review from likeamike likeamike is a code owner

Assignees

@Gimir Gimir

Labels
bug Something isn't working _priority_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gimir @IlyaBondar