fix(chat): fix error api error message parsing (Issue #1481)

apps/chat/src/pages/api/share/accept.ts

@@ -35,20 +35,8 @@ const handler = async (req: NextApiRequest, res: NextApiResponse) => {
       },
     );
 
-    let json: unknown;
     if (!proxyRes.ok) {
-      try {
-        json = await proxyRes.json();
-      } catch (err) {
-        json = undefined;
-      }
-
-      throw new DialAIError(
-        (typeof json === 'string' && json) || proxyRes.statusText,
-        '',
-        '',
-        proxyRes.status + '',
-      );
+      throw new DialAIError(proxyRes.statusText, '', '', proxyRes.status + '');
     }
 
     return res.status(200).send(JSON.stringify({}));

apps/chat/src/store/share/share.epics.ts

@@ -287,7 +287,7 @@ const acceptInvitationEpic: AppEpic = (action$) =>
         catchError((err) => {
           console.error(err);
           let message = errorsMessages.acceptShareFailed;
-          if (err.message === '404') {
+          if (err.message.trim().toLowerCase() === 'not found') {
             message = errorsMessages.acceptShareNotExists;
           }
           return of(ShareActions.acceptShareInvitationFail({ message }));

apps/chat/src/utils/server/api.ts

@@ -1,6 +1,8 @@
-import { Observable, catchError, from, switchMap, throwError } from 'rxjs';
+import { Observable, from, switchMap, throwError } from 'rxjs';
 import { fromFetch } from 'rxjs/fetch';
 
+import { ServerUtils } from '@/src/utils/server/server';
+
 import { Conversation, ConversationInfo } from '@/src/types/chat';
 import { PromptInfo } from '@/src/types/prompt';
 
@@ -107,11 +109,12 @@ export class ApiUtils {
     }).pipe(
       switchMap((response) => {
         if (!response.ok) {
-          return from(response.text()).pipe(
-            switchMap((errorMessage) =>
-              throwError(() => new Error(errorMessage)),
-            ),
-            catchError(() => throwError(() => new Error(response.status + ''))),
+          return from(ServerUtils.getErrorMessageFromResponse(response)).pipe(
+            switchMap((errorMessage) => {
+              return throwError(
+                () => new Error(errorMessage || response.status + ''),
+              );
+            }),
           );
         }
 

apps/chat/src/utils/server/server.ts

@@ -3,7 +3,7 @@ import { NextApiRequest } from 'next';
 import { constructPath } from '../app/file';
 import { ApiUtils } from './api';
 
-import { Response } from 'node-fetch';
+import { Response as NodeFetchResponse } from 'node-fetch';
 
 export class ServerUtils {
   public static getEntityTypeFromPath = (
@@ -20,16 +20,18 @@ export class ServerUtils {
     );
 
   public static getErrorMessageFromResponse = async (
-    res: Response,
+    res: Response | NodeFetchResponse,
   ): Promise<string | null> => {
     try {
-      return (await res.json()) as string;
-    } catch {
+      const text = await res.text();
       try {
-        return await res?.text();
+        const json = JSON.parse(text);
+        return typeof json === 'string' ? json : JSON.stringify(json);
       } catch {
-        return null;
+        return text;
       }
+    } catch {
+      return null;
     }
   };
 }