fix(query): split query should be able to run when step > (end - start) #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boyuan-Yu
changed the title
added 12 commits
January 9, 2025 10:39
|
retest this please |
|
test this please |
|
retest this please |
alextheimer
previously approved these changes
Jan 17, 2025
coordinator/src/main/scala/filodb.coordinator/queryplanner/MultiPartitionPlanner.scala
Show resolved
Hide resolved
alextheimer
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior :
When we have a query that cross the namespace migration point, it's trying to stitch two series from two partitions. The first partition gives the time range (start, start + step), the end time of this range is larger than the end time of the query so it gives this error:
New behavior :
The query has one exec plan for the partition before the split. No need to stitch.