fix(query): enforce legacy failover when needed #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-shipit
approved these changes
Jan 21, 2025
kvpetrov
added a commit
to kvpetrov/FiloDB
that referenced
this pull request
Jan 21, 2025
Co-authored-by: Kier Petrov <[email protected]>
kvpetrov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior :
If shard level failover is enabled but is not required, ie the local cluster is not healthy but the remote cluster is healthy we switch to legacy failover when promql is issued to the buddy cluster. However, the query context parameters still have shard level failover flag enabled that does not allow to properly resolve shards.
New behavior :
When legacy failover is enabled the query context parameter is set to "legacy".
BREAKING CHANGES
n/a